Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pyway to mange MPI migrations #824

Merged
merged 27 commits into from
Sep 13, 2023
Merged

Implement pyway to mange MPI migrations #824

merged 27 commits into from
Sep 13, 2023

Conversation

DanPaseltiner
Copy link
Collaborator

PULL REQUEST

Summary

This PR introduces pyway for managing migrations on the MPI.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #824 (5685ea3) into main (977867e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          45       45           
  Lines        2626     2626           
=======================================
  Hits         2532     2532           
  Misses         94       94           
Flag Coverage Δ
unit-tests 96.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@BradySkylight BradySkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Added logging as well, which will help so much with TS if there are issues.

@DanPaseltiner DanPaseltiner merged commit ee559e5 into main Sep 13, 2023
24 checks passed
@DanPaseltiner DanPaseltiner deleted the implement-pyway branch September 13, 2023 18:50
@DanPaseltiner
Copy link
Collaborator Author

This is great! Added logging as well, which will help so much with TS if there are issues.

I think we should look at adding this logging to our other services. Not an immediate issue, but something to keep on the back burner.

@nickclyde nickclyde mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants